merge main -> new-update#1657
Merged
Merged
Conversation
… REG_SZ instead of REG_DWORD The three values rewritten in `HKCU\Keyboard Layout\Toggle` should be of type REG_SZ: https://github.com/Atlas-OS/Atlas/blob/0b41102f1ee9696274a177db6aa913b8481377de/src/playbook/Executables/AtlasModules/Scripts/Modules/Qol/Qol.psm1#L47-L50 Expectation: <img width="1052" height="646" alt="Image" src="https://github.com/user-attachments/assets/7894fb5b-460f-46dd-b634-a5c23b4c432a" /> I also checked the `HKCU\Control Panel\Accessibility\...` `Flag` values rewritten in the same function in the registry in a stock install of Windows, and those were also of type REG_SZ, so have patched those too. I have not checked other values in other functions. We received reports of this causing crashes in Keyman; see keymanapp/keyman#14342. (We have now patched Keyman to work around the unexpected data type.)
Bumps the template to 25H2, which is the current Windows release that is supported by AtlasOS.
github-actions
Bot
added
playbook
There was a problem hiding this comment.
Pull request overview
This PR appears to be a merge sync that includes a few small fixes/adjustments across the playbook scripts and GitHub configuration.
Changes:
- Fixes the PowerShell device list formatting in
DISABLEPNP.ps1(adds the missing array element separator). - Updates QoL registry writes to use
REG_SZfor severalFlags/hotkey values. - Changes Network Discovery’s “unpin Network from Explorer sidebar” step to call an existing
.cmdinstead of importing a.reg. - Updates
.github/labeler.ymlglobs to thesrc/playbook/...layout and tweaks the bug report template’s version dropdown options.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/playbook/Executables/DISABLEPNP.ps1 | Fixes array entry formatting for the device friendly-name list. |
| src/playbook/Executables/AtlasModules/Scripts/Modules/Qol/Qol.psm1 | Changes registry value types for several accessibility/hotkey-related entries. |
| src/playbook/Executables/AtlasDesktop/6. Advanced Configuration/Services/Network Discovery/Disable Network Discovery Services.cmd | Replaces .reg import with a .cmd call for disabling the Network navigation pane. |
| .github/labeler.yml | Updates labeler paths to match src/playbook directory structure. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Adjusts the “Atlas Version” dropdown options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| :: Unpin 'Network' from Explorer sidebar | ||
| reg import "%windir%\AtlasDesktop\3. General Configuration\File Sharing\Network Navigation Pane\Disable Network Navigation Pane (default).reg" > nul | ||
| call "%windir%\AtlasDesktop\3. General Configuration\File Sharing\Network Navigation Pane\Disable Network Navigation Pane (default).cmd" > nul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions
Describe your pull request