fix: correctly track client errors #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeantonio21
requested changes
May 28, 2025
jorgeantonio21
approved these changes
May 29, 2025
jorgeantonio21
added a commit
that referenced
this pull request
Jun 5, 2025
* fix: correctly track client errors (#493) * fix: correctly track 400 errors * fix: update to correctly use status code * fix: track errors more granularly * chore: remove unnecessary clones * chore: some more clippy clean up * ci: use stable toolchain (#497) * ci: use stable toolchain * chore: address clippy issues * chore: fix type * chore: refactor sending atoma state manager event (#499) * update sui dependencies (#506) --------- Co-authored-by: Chad Nehemiah <[email protected]> Co-authored-by: Martin Stefcek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't necessarily want to monitor all client errors for observability, but rather
429s