fix: re-enable escrow, batch_approval, batch_history, multi_signer, batch_swap_features, prop, chaos tests - #957
Merged
fejilaup-cloud merged 1 commit intoAug 29, 2026
Conversation
…atch_swap_features, prop, chaos tests Fixed pre-existing compile errors caused by updated function signatures after merge conflicts. All affected test modules are now re-enabled in lib.rs. Changes per module: - escrow_tests (AtomicIP#830): commit_ip now takes &pow_difficulty: &u32; pass &0u32 - batch_approval_tests (AtomicIP#831): same commit_ip fix - batch_history_tests (AtomicIP#832): commit_ip fix + remove extra Bytes arg from cancel_swap (signature is cancel_swap(swap_id, canceller), no reason/bytes arg) - multi_signer_tests (AtomicIP#824): commit_ip fix (already landed, included here) - batch_swap_features_tests (AtomicIP#825): commit_ip fix + &0i128 for initiate_swap + mint &0 to hardcoded treasury so batch_reveal_keys fee transfer succeeds - prop_tests (AtomicIP#828): commit_ip fix + &0i128 for initiate_swap + cancel_swap with &seller - chaos_tests (AtomicIP#829): re-enabled (signatures already correct)
|
@cephas360 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables 7 test modules that were disabled with
FIXMEcomments after merge conflicts introduced compile errors. All errors were caused by updated function signatures that the test files hadn't been updated to match.Changes
escrow_testscommit_ip: add missing&0u32(pow_difficulty) argbatch_approval_testscommit_ip: add missing&0u32argbatch_history_testscommit_ip: add&0u32;cancel_swap: remove extraBytesarg (signature iscancel_swap(swap_id, canceller))multi_signer_testscommit_ip: add&0u32argbatch_swap_features_testscommit_ip+initiate_swap(&0i128) fixes; mint&0to hardcoded treasury sobatch_reveal_keysprotocol-fee transfer succeeds in testsprop_testscommit_ip+initiate_swap(&0i128) +cancel_swapwith&sellerchaos_testslib.rsTesting
All 7 modules are re-enabled in
lib.rsand the compile errors are resolved. No logic changes — only call-site argument updates to match current function signatures.closes
closes #829
closes #828
closes #825
closes #824