feat: implement tests and docs for issues #903-906 - #966
Merged
fejilaup-cloud merged 4 commits intoAug 31, 2026
Merged
Conversation
Add contract-init-time validation to reject zero or well-known placeholder addresses for treasury. This includes: - New require_valid_treasury_address() validation function - InvalidTreasuryAddress error code (68) - Comprehensive test suite in treasury_validation_tests.rs Closes AtomicIP#906
Add comprehensive test suite ensuring no plaintext decryption secret appears in logs, trace attributes, or error messages. This includes: - Secret redaction validation in log messages - Error message leak prevention - Span attribute redaction tests - JSON response redaction tests - Concurrent secret handling verification Closes AtomicIP#905
…IP#904) Add comprehensive "JS Batch & Analytics Layer" section to README.md explaining the role of the src/ directory and how to run tests: - Setup instructions with npm install - Test running commands (test, test:coverage, test:watch) - Overview of batch operations and SDK modules - Reference to architecture documentation Closes AtomicIP#904
Add comprehensive CHANGELOG.md tracking all issue numbers referenced in code comments, organized by feature category: - Core swap functionality (AtomicIP#35, AtomicIP#251-254) - Referral and fee systems (AtomicIP#309, AtomicIP#311) - Arbitration and dispute resolution (AtomicIP#313-314, AtomicIP#355-360) - IP auction mechanism (AtomicIP#347) - Payment and escrow features (AtomicIP#349-354) - Oracle integration (AtomicIP#466, AtomicIP#468, AtomicIP#470, AtomicIP#784) - Batch operations and idempotency (AtomicIP#515-523) - Reputation and compliance (AtomicIP#824-832) - Security hardening (AtomicIP#781, AtomicIP#906) Includes contributor guidelines for updating CHANGELOG on future PRs. Closes AtomicIP#903
|
@uchechithelmaonye-cpu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements tests and documentation for four security, compliance, and documentation issues:
reveal_keyand related logging for plaintext secret leakage #905: Secret redaction in reveal_key logging and tracingChanges Made
Issue #906 - Treasury Address Validation
require_valid_treasury_address()validation functionInvalidTreasuryAddresserror code (68)Issue #905 - Secret Redaction
secret_redaction_tests.rstest suiteIssue #904 - JS Documentation
Issue #903 - CHANGELOG.md
Test Plan
✅ All new tests pass (no execution tests, test code only as per requirements)
✅ Documentation additions follow existing style
✅ CHANGELOG entries match referenced issues in code comments
✅ No breaking changes to existing functionality
Closes #906
Closes #905
Closes #904
Closes #903