cleanup tasks #364
Merged
cleanup tasks #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upload_image_task is a blocking function, so run the tasks inside of a created executor thread, which then gives better handling of other async tasks (say keyboard interrupt) and doesn't use the default python executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was given the idea to except more than just keyboard interruptions, which sent me down a rabbit hole of checking tasks everywhere.
Turns out pooling with multiprocessing is async blocking which prevented proper handling (on windows at least) of CTRL+C.
Specifically creating and passing
ProcessPoolExecutorinstead of the default executor solved the lack of threading performance I was seeing previously.