-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the architecture #27
Open
bygu4
wants to merge
23
commits into
Aunsiels:master
Choose a base branch
from
FormalLanguageConstrainedPathQuerying:rework_architecture
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework the architecture #27
bygu4
wants to merge
23
commits into
Aunsiels:master
from
FormalLanguageConstrainedPathQuerying:rework_architecture
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework several modules and their relations with adding type annotations. The following modules were affected:
In more detail, we can describe the changes as follows.
|
@Aunsiels
I would suggest creating a separate branch where we can try merging all of that |
94af59a
to
1d1e8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we plan to rework the architecture of Pyformlang library, removing cyclic imports and hopefully making the design clearer. That would further allow us to add type annotations for most of the code, improving its rigor and readability as well as the interface of the project. For more detail, see issues: