Skip to content

Conversation

@Tel0k
Copy link

@Tel0k Tel0k commented Sep 16, 2024

No description provided.

@kgirtxd kgirtxd linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few missing "2024" notations in proficiencies-all.xml.

Also, should we keep vehicle proficiencies? They seem to have been removed from the PHB24.

Comment on lines +777 to +793
<element name="Tool Proficiency (Vehicles (land))" type="Proficiency" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_VEHICLES_LAND">
<supports>Tool, Vehicles</supports>
<requirements />
<description>
<p></p>
</description>
<rules />
</element>
<element name="Tool Proficiency (Vehicles (water))" type="Proficiency" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_VEHICLES_WATER">
<supports>Tool, Vehicles</supports>
<requirements />
<description>
<p>You gain proficiency with Vehicles (water).</p>
</description>
<rules />
</element>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed these aren't actually in the PHB24 book anywhere. It seems they removed vehicle proficiencies with the version update?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages 229 and 230 of PHB24, those have actually been added to the new PHB while in the previous edition they were part of DMG

Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some typos found in my latest testing sessions.

</element>

<element name="Persuasion" type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_PERSUASION" source="Player’s Handbook 2024">
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin</supports>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin</supports>
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin,ID_WOTC_PHB24_CLASS_FIGHTER,Fighter</supports>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that the Weapon Mastery class feature grants the mastery effects of specific weapons. Would this not be giving mastery for several extra weapons?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be interpreted like that, but as long as you keep track of what weapon you are choosing to have mastery, it's not really a big problem.. even then it's still pending a review so it may change in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DDB has you select specific weapons

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was DDB?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D&D Beyond

Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review, Part 1

Comment on lines 5 to 6
<description></description>
<author url="http://dnd.wizards.com/products/tabletop-games/rpg-products/rpg_playershandbook">Wizards of the Coast</author>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description></description>
<author url="http://dnd.wizards.com/products/tabletop-games/rpg-products/rpg_playershandbook">Wizards of the Coast</author>
<description>Armors from the Player’s Handbook 2024.</description>

</update>
</info>

<!-- light armor -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- light armor -->

<element name="Padded" type="Armor" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARMOR_LIGHT_PADDED">
<supports>ID_INTERNAL_ARMOR_GROUP_LIGHT</supports>
<description>
<p>Padded armor consists of quilted layers of cloth and batting.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Padded armor consists of quilted layers of cloth and batting.</p>
<p class="flavor">1 Minute to Don or Doff</p>
<p>Padded armor consists of quilted layers of cloth and batting.</p>

Comment on lines 19 to 26
<set name="category">Armor</set>
<set name="cost" currency="gp">5</set>
<set name="weight" lb="8">8 lb.</set>
<set name="slot">body</set>
<set name="armor">Light</set>
<set name="armorClass">11 + Dex modifier</set>
<set name="stealth">Disadvantage</set>
<set name="proficiency">ID_WOTC_PHB24_PROFICIENCY_ARMOR_PROFICIENCY_PADDED</set>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<set name="category">Armor</set>
<set name="cost" currency="gp">5</set>
<set name="weight" lb="8">8 lb.</set>
<set name="slot">body</set>
<set name="armor">Light</set>
<set name="armorClass">11 + Dex modifier</set>
<set name="stealth">Disadvantage</set>
<set name="proficiency">ID_WOTC_PHB24_PROFICIENCY_ARMOR_PROFICIENCY_PADDED</set>
<set name="category">Armor</set>
<set name="armor">Light</set>
<set name="armorClass">11 + Dex modifier</set>
<set name="stealth">Disadvantage</set>
<set name="weight" lb="8">8 lb.</set>
<set name="cost" currency="gp">5</set>
<set name="slot">body</set>
<set name="proficiency">ID_WOTC_PHB24_PROFICIENCY_ARMOR_PROFICIENCY_PADDED</set>

<grant type="Grants" id="ID_INTERNAL_GRANTS_STEALTH_DISADVANTAGE" />
<stat name="ac:armored:armor" value="11" />
</rules>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</element>
</element>

<set name="weight" lb="1">1 lb.</set>
<set name="stackable">true</set>
</setters>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</element>
</element>

<set name="weight" lb="1">1 lb.</set>
<set name="stackable">true</set>
</setters>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</element>
</element>

<set name="weight" lb="1">—</set>
<set name="stackable">true</set>
</setters>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</element>
</element>

</element>
<element name="Waterskin" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_WATERSKIN">
<description>
<p>A Waterskin holds up to 4 pints. If you don't drink sufficient water, you risk dehydration (see the rules glossary).</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>A Waterskin holds up to 4 pints. If you don't drink sufficient water, you risk dehydration (see the rules glossary).</p>
<p>A Waterskin holds up to 4 pints. If you don't drink sufficient water, you risk dehydration.</p>
<div class="reference">
<div element="ID_WOTC_PHB24_RULE_DEHYDRATION" />
</div>

Comment on lines 1172 to 1183
<!--
<element name="Whetstone" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_WHETSTONE">
<description>
<p></p>
</description>
<setters>
<set name="category">Adventuring Gear</set>
<set name="cost" currency="cp">1</set>
<set name="weight" lb="1">1 lb.</set>
<set name="stackable">true</set>
</setters>
</element>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--
<element name="Whetstone" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_WHETSTONE">
<description>
<p></p>
</description>
<setters>
<set name="category">Adventuring Gear</set>
<set name="cost" currency="cp">1</set>
<set name="weight" lb="1">1 lb.</set>
<set name="stackable">true</set>
</setters>
</element>-->
<!-- to do: move all PHB24 Rule type elements into their own file -->
<element name="Dehydration [Hazard]" type="Rule" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_RULE_DEHYDRATION">
<description>
<p>A creature requires an amount of water per day based on its size, as shown in the Water Needs per Day table. A creature that drinks less than half the required water for a day gains 1 Exhaustion level at the day's end. Exhaustion caused by dehydration can't be removed until the creature drinks the full amount of water required for a day.</p>
<h5>Water Needs per Day</h5>
<table>
<thead>
<tr><td>Size</td><td>Water</td></tr>
</thead>
<tr><td>Tiny</td><td>1/4 gallon</td></tr>
<tr><td>Small</td><td>1 gallon</td></tr>
<tr><td>Medium</td><td>1 gallon</td></tr>
<tr><td>Large</td><td>4 gallons</td></tr>
<tr><td>Huge</td><td>16 gallons</td></tr>
<tr><td>Gargantuan</td><td>64 gallons</td></tr>
</table>
</description>
<setters>
<set name="keywords">drinking, water, exhaustion</set>
</setters>
</element>

NickVendel

This comment was marked as duplicate.

Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 2. The rest of the files, including Proficiencies, Languages and Expertise elements are likely going to be changed during last stages of PHB24 review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be deleted, as i moved all of the Musical Instruments into items-tools.xml

Comment on lines 4 to 6
<name>Mounts and Vehicles</name>
<description></description>
<author url="http://dnd.wizards.com/products/tabletop-games/rpg-products/rpg_playershandbook">Wizards of the Coast</author>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<name>Mounts and Vehicles</name>
<description></description>
<author url="http://dnd.wizards.com/products/tabletop-games/rpg-products/rpg_playershandbook">Wizards of the Coast</author>
<name>Mounts and Vehicles</name>
<description>Mounts and Vehicles from Player's Handbook 2024</description>

Comment on lines 10 to 11
</info>
<element name="Camel" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_CAMEL">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</info>
<element name="Camel" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_CAMEL">
</info>
<!-- Barding was never properly implemented, and is currently not planned, as it don't affect the character in any way. Still maybe at some point in the future it would make sense to adapt normal armor into barding at least for an ease of tracking it for users -->
<element name="Barding" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_BARDING">
<description>
<p>Barding is armor designed for a mount. Any type of armor on the Armor table in this chapter can be purchased as barding. The cost is four times the normal cost, and it weighs twice as much.</p>
</description>
<setters>
<set name="category">Mounts &amp; Vehicles</set>
<set name="cost" currency="gp">0</set>
<set name="weight" lb="0">—</set>
</setters>
</element>
<element name="Camel" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_CAMEL">

</info>
<element name="Camel" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_CAMEL">
<description>
<p><strong><em>Speed.</em></strong> 50 ft.<br/><strong><em>Carrying Capacity.</em></strong> 450 lb.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><strong><em>Speed.</em></strong> 50 ft.<br/><strong><em>Carrying Capacity.</em></strong> 450 lb.</p>
<h4 style="margin-top:0px" />
<p><em>Large Beast, Unaligned</em></p>
<ul class="unstyled mb">
<li style="margin-bottom:-1em"><strong>AC</strong> 10</li>
<li style="text-align:right; margin-top:-1em"><strong>Initiative</strong> -1 (9)</li>
<li style="margin-bottom:-1em"><strong>HP</strong> 17 (2d10 + 6)</li>
<li style="text-align:right; margin-top:-1em"><strong>Carrying Capacity</strong> 450 lb.</li>
<li><strong>Speed</strong> 50 ft.</li>
</ul>
<table style="text-align:center">
<thead><tr><td> </td><td> </td><td>MOD</td><td>SAVE</td><td> </td><td> </td><td>MOD</td><td>SAVE</td><td> </td><td> </td><td>MOD</td><td>SAVE</td></tr></thead>
<tr><td>STR</td><td>15</td><td>+2</td><td>+2</td><td>DEX</td><td>8</td><td>-1</td><td>-1</td><td>CON</td><td>17</td><td>+3</td><td>+5</td></tr>
<tr><td>INT</td><td>2</td><td>-4</td><td>-4</td><td>WIS</td><td>11</td><td>+0</td><td>+0</td><td>CHA</td><td>5</td><td>-3</td><td>-3</td></tr>
</table>
<ul class="unstyled">
<li><strong>Senses</strong> Darkvision 60ft., Passive Perception 10</li>
<li><strong>Languages</strong> None</li>
<li><strong>Challenge</strong> 1/8 (XP 25; PB +2)</li>
</ul>
<h4 style="margin-top:10px">Actions</h4>
<ul class="unstyled">
<li><strong><em>Bite. </em></strong><em>Melee Weapon Attack:</em> +4, reach 5 ft. <em>Hit:</em> 4 (1d4 + 2) Bludgeoning damage.</li>
</ul>

Comment on lines 21 to 44
</element>
<!--
<element name="Donkey" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_DONKEY">
<description>
<p><strong><em>Speed.</em></strong> 40 ft.<br/><strong><em>Carrying Capacity.</em></strong> 420 lb.</p>
</description>
<setters>
<set name="category">Mounts &amp; Vehicles</set>
<set name="cost" currency="gp">8</set>
<set name="weight" lb="0">—</set>
<set name="type">Mount</set>
</setters>
</element> -->
<element name="Mule" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_MULE">
<description>
<p><strong><em>Speed.</em></strong> 40 ft.<br/><strong><em>Carrying Capacity.</em></strong> 420 lb.</p>
</description>
<setters>
<set name="category">Mounts &amp; Vehicles</set>
<set name="cost" currency="gp">8</set>
<set name="weight" lb="0">—</set>
<set name="type">Mount</set>
</setters>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mule is moved below

Suggested change
</element>
<!--
<element name="Donkey" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_DONKEY">
<description>
<p><strong><em>Speed.</em></strong> 40 ft.<br/><strong><em>Carrying Capacity.</em></strong> 420 lb.</p>
</description>
<setters>
<set name="category">Mounts &amp; Vehicles</set>
<set name="cost" currency="gp">8</set>
<set name="weight" lb="0">—</set>
<set name="type">Mount</set>
</setters>
</element> -->
<element name="Mule" type="Item" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ITEM_MULE">
<description>
<p><strong><em>Speed.</em></strong> 40 ft.<br/><strong><em>Carrying Capacity.</em></strong> 420 lb.</p>
</description>
<setters>
<set name="category">Mounts &amp; Vehicles</set>
<set name="cost" currency="gp">8</set>
<set name="weight" lb="0">—</set>
<set name="type">Mount</set>
</setters>
</element>
</element>

<description>If you hit a creature with this weapon and deal damage to the creature, you have Advantage on your next attack roll against that creature before the end of your next turn.</description>
</sheet>
</element>
<element name="Shortsword (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_SHORTSWORD_VEX">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Shortsword (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_SHORTSWORD_VEX">
<element name="Shortsword (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_MASTERY_PROPERTY_SHORTSWORD_VEX">

<description>If you hit a creature with this weapon and deal damage to the creature, you have Advantage on your next attack roll against that creature before the end of your next turn.</description>
</sheet>
</element>
<element name="Blowgun (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_BLOWGUN_VEX">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Blowgun (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_BLOWGUN_VEX">
<element name="Blowgun (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_MASTERY_PROPERTY_BLOWGUN_VEX">

<description>If you hit a creature with this weapon and deal damage to the creature, you have Advantage on your next attack roll against that creature before the end of your next turn.</description>
</sheet>
</element>
<element name="Crossbow, Hand (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_CROSSBOW_HAND_VEX">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Crossbow, Hand (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_CROSSBOW_HAND_VEX">
<element name="Crossbow, Hand (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_MASTERY_PROPERTY_CROSSBOW_HAND_VEX">

<description>If you hit a creature with this weapon and deal damage to the creature, you have Advantage on your next attack roll against that creature before the end of your next turn.</description>
</sheet>
</element>
<element name="Pistol (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_PISTOL_VEX">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Pistol (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_WPM_PISTOL_VEX">
<element name="Pistol (Vex)" type="Class Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_CLASS_FEATURE_MASTERY_PROPERTY_PISTOL_VEX">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file can be deleted. Properties seems to be hardcodded, and since they're already part of the Internal source, there's no need to do anything with them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it would be ok to delete it.. even if properties are hardcoded, we should keep these at least for compendium purposes, as phb24 ones have differences in wording compared to old phb14 ones..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or at least change them to type="Rule"?

Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hate these typos, only noticed them when working on spells file and encountering similar issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Items, proficiencies, properties, languages and alignments

5 participants