Skip to content

Add minimum pop requirements to greim events #20716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Batrachophreno
Copy link
Contributor

@Batrachophreno Batrachophreno commented Apr 16, 2025

See title. Adds additional requirement of a minimum 8 pop to Greimorian Infestation events to reduce common lowpop headaches.

Set min pop reqs for events to 1, reduce the likelihood of the Horizon turning into a genestealer-infested space hulk during long uptime.

@Batrachophreno
Copy link
Contributor Author

!review

@Fyshen
Copy link

Fyshen commented Apr 16, 2025

Does radstorm need to have a pop requirement? It merely requires some people to move - and per the rules people shouldn't be AFKing for extended periods anyway, so should not be at risk of it.

@Batrachophreno
Copy link
Contributor Author

Does radstorm need to have a pop requirement? It merely requires some people to move - and per the rules people shouldn't be AFKing for extended periods anyway, so should not be at risk of it.

I'll paste my thoughts from discord here, since it is a legit question you ask! https://discord.com/channels/157516682288562176/725470666039754783/1362094530513600775 (there's additional discussion from others on the subject preceding that).
Quoting myself:

Well, there's already controls in place for minimum medical, minimum security, etc, based on role weights [for the radstorm event, in addition to a new min pop requirement]
Quite frankly though, given likelihood that some characters are just off doing their own thing mining, or doing off-ships, or etc., I personally didn't feel that balance was Too big a concern when the overriding goal is to make lowpop a bit less aggravating- if one in every 5 times the event fires, it turns out to be an actual PITA, that's pretty discouraging to logging in
Since honestly- if you die to greimorians or rads when theres like 3 other people around, its not really going to be adding much to a compelling time IMO. (Though I don't really care about the actual pop number- 8 or 5 or whatever one wants)

It's very much more a quality of life/trying to reduce gameplay/roleplay friction in lowpop to encourage it (since every highpop outside peak hours by necessity STARTS with lowpop), than it is trying to address any hard balance concerns.

(I also said screw it, made it events won't fire in a vacuum with 0 players. There's nothing gained from finding everything covered in flour and every vending machine hucking stuff at you when first logging on after a lull.)

@FlamingLily
Copy link
Contributor

Pop requirements are fine but the two types of infestation events do have a meaningful difference, with one being where eggs spawn in one specific room, and the other where larvae just spawn everywhere. Personally I would prefer to keep both and, if you need to add a pop requirement to the eggs event, do so.

Copy link
Contributor

@hazelrat hazelrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two different versions of the greimorian event are tangibly different and prompt different responses from the crew. If you want to make greimorian infestations less prominent, please make either or both slightly less likely instead of removing either. Less variety in random events isn't desirable.

Additionally, I don't see any good reason why a radiation storm needs to be limited by population. Its lethality isn't influenced by how high the population is.

I think the minimum population requirement for greimorian infestations is fine.

@hazelrat hazelrat added the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 17, 2025
@Batrachophreno Batrachophreno changed the title Add minimum pop requirements to radstorm, greim events Add minimum pop requirements to greim events Apr 17, 2025
@Batrachophreno
Copy link
Contributor Author

No worries re: radstorms, and The More You Know re: the two greimorian events being appreciably different in-game, that's my bad! Updated so that only greims (both variants) require minimum 8 players.

@Batrachophreno Batrachophreno requested a review from hazelrat April 17, 2025 14:31
@Batrachophreno Batrachophreno requested a review from hazelrat April 18, 2025 14:49
@hazelrat hazelrat removed the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 29, 2025
Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The excel file containing the event probabilities needs to be updated with these changes.

@Batrachophreno
Copy link
Contributor Author

The excel file containing the event probabilities needs to be updated with these changes.

Didn't know that existed, neat! I looked through it though and it doesn't appear to have a section or column for minimum population requirements for me to update. There is a column for ASSIGNMENT_ANY, but I used pop_needed for this. You want me to throw in two extra columns in there for minimum and maximum pop requirements for each event?

@Batrachophreno Batrachophreno requested a review from Arrow768 May 9, 2025 15:20
@Arrow768
Copy link
Member

The excel file containing the event probabilities needs to be updated with these changes.

Didn't know that existed, neat! I looked through it though and it doesn't appear to have a section or column for minimum population requirements for me to update. There is a column for ASSIGNMENT_ANY, but I used pop_needed for this. You want me to throw in two extra columns in there for minimum and maximum pop requirements for each event?

Yes please. That would be useful

@github-actions github-actions bot added the Tools label May 11, 2025
@Batrachophreno
Copy link
Contributor Author

Column for min pop added and populated for current events- should be all set.

@Batrachophreno
Copy link
Contributor Author

Polite ping on this, confirming the requested changes have been made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants