Skip to content

Offbrand sightlights #20722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Batrachophreno
Copy link
Contributor

(DISCLAIMER: I currently mostly play an engineer!)

Sightlights are currently only available to Medical, Science, and Bridge personnel- but arguably (strongly arguably) Engineering is actually the department most likely to be regularly walking through very dark areas (see: areas with power outages, and maintenance tunnels). Certainly more commonly than Med and Bridge in almost any given shift!

I don't think this is particularly balance-breaking, and I think it makes a lot of sense, so here it is.

Also minor cleanup to description.

@Greenjoe12345
Copy link
Contributor

That isn't going to work. They're restricted to Zeng-hu, which cannot be engineering

@Batrachophreno
Copy link
Contributor Author

Oh, dang. Okay that's a great point. Is it acceptable to make them non Zeng-Hu-aligned you think? They seem pretty... broadly applicable, not just research-focused.

Copy link
Contributor

@hazelrat hazelrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is, sightlights are part of a set of several Zeng-Hu augments, all of which are specific and exclusive only to Zeng-Hu staff. I think these are more valuable providing Zeng-Hu a unique identity than they would be if they were expanded to more crew.

@Batrachophreno
Copy link
Contributor Author

Batrachophreno commented Apr 24, 2025

Hmm, I am reading you- to provide corp employees with its own exclusive perks/features Is a valid/effective/easy method of promoting their unique identities. While I still feel an integrated flashlight is sufficiently basic that it'd be more broadly available, I get behind it. I still want to see more augments/built-in tools available, so I will think on it before attacking w/ a new PR.

Will try my luck rq before closing this: What about shitty shorter-range colorless flashlights for average joes, and brighter, fashionably pale violet-tinged flashlight eyes for Zeng-Hu folks? Eh eh eh? Still fancy and unique Zeng kit, lesser option available to everyone, totally no self-interest here?

@hazelrat
Copy link
Contributor

Will try my luck rq before closing this: What about shitty shorter-range colorless flashlights for average joes, and brighter, fashionably pale violet-tinged flashlight eyes for Zeng-Hu folks? Eh eh eh? Still fancy and unique Zeng kit, lesser option available to everyone, totally no self-interest here?

I wouldn't be opposed to this, so long as the generic variant has a sufficiently substantially lower luminosity than the Zeng-Hu type. It may be worth passing it by lore before you begin work on it, though.

@Batrachophreno
Copy link
Contributor Author

!wip

@BotBOREALIS BotBOREALIS added WIP The PR is a work in progress and should not be reviewed yet. and removed Review Required labels Apr 26, 2025
@Batrachophreno
Copy link
Contributor Author

Batrachophreno commented May 4, 2025

..i dont know why it automatically added you as a reviewer matt, sorry

EDIT: also, this got okayed by trio and kermit on the lore front: https://discord.com/channels/724651070017765459/853160492004016149/1367238496829440080

@Batrachophreno Batrachophreno changed the title Sightlights available to Engineering personnel Offbrand sightlights May 7, 2025
@Batrachophreno
Copy link
Contributor Author

!review

@BotBOREALIS BotBOREALIS added Review Required and removed WIP The PR is a work in progress and should not be reviewed yet. labels May 8, 2025
@NonQueueingMatt NonQueueingMatt added the Changes Required The PR requires changes before it can be approved and/or merged. label May 9, 2025
@Batrachophreno
Copy link
Contributor Author

Pinged lore team on this- should be all set

@Batrachophreno
Copy link
Contributor Author

Polite ping on this, just confirming that the requested changes have been made!

display_name = "offbrand ocular sightlights"
description = "Designed to assist personnel in darker areas or places experiencing periodic power issues, Sightlights allow one to use their eyes as a flashlight. Later SCC-mediated negotiation loosened the augment's patent restrictions, allowing offbrand manufacture and use of lesser models by other members of the Chainlink."
path = /obj/item/organ/internal/augment/sightlights/generic
whitelisted = list(SPECIES_HUMAN, SPECIES_HUMAN_OFFWORLD, SPECIES_VAURCA_WORKER, SPECIES_VAURCA_WARRIOR, SPECIES_VAURCA_ATTENDANT, SPECIES_VAURCA_BULWARK, SPECIES_SKRELL, SPECIES_SKRELL_AXIORI, SPECIES_IPC, SPECIES_IPC_G1, SPECIES_IPC_G2, SPECIES_IPC_XION, SPECIES_IPC_ZENGHU, SPECIES_IPC_BISHOP, SPECIES_IPC_SHELL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be limited to the same species as the Zeng-Hu variant? I feel it could be opened to Unathi and Tajara too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch/thinking, I agree with that. Zeng-Hu isn't necessarily the manufacturer for all the offbrand models- could argue that they never created designs adaptable to the two species but I'd much rather open up access.

Will update tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Required The PR requires changes before it can be approved and/or merged. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants