Skip to content

Improve, cleanup, and expand wound code #20757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Generalcamo
Copy link
Contributor

This PR includes several changes to bring our wound code up to date with baystation, nebula, and modern standards. Highlights include:

  • The usage of integers between 0 and 100 for ratios (expressed as a percentage), instead of 0.0 to 1.0. Small decimal values are prone to rounding errors, but by moving to a percentage instead, we can reduce the impact of this.
  • The untangling of damage flags and injury flags, which were used interchangably in the code. This could cause issues should we expand any of these.
  • Larger embedded objects now halt bleeding in wounds, until they are pulled out. In exchange however, embedded objects will halt healing in wounds (it is difficult to close an open wound that currently has a rod stuck in it)
  • A lot of data, such as implanted objects and organs, are now stored in amputated limbs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants