Skip to content

Wires interface must require panel to be open #20764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Batrachophreno
Copy link
Contributor

#18299

Original bug report was for Air Alarms always displaying their wiring interface when interacted with, even when the maintenance panel was still closed.

I found a few other objects which also did not correctly check if wires were accessible before displaying the interface.

There also remains some inconsistency: some objects will always display the wire interface when clicked on with panel open, but others require you to have certain tools in hand too (wirecutter, multitool, etc.). Without them in-hand, they won't give you the wire UI. I'm indifferent to which option is better, but it should be made consistent. If someone feels at all strongly about having tools in-hand vs. not to see the interface, then I can also make that change with whatever the prevailing opinion is.

@Batrachophreno
Copy link
Contributor Author

!wip

@BotBOREALIS BotBOREALIS added the WIP The PR is a work in progress and should not be reviewed yet. label May 15, 2025
@Batrachophreno
Copy link
Contributor Author

!bugfix

@BotBOREALIS BotBOREALIS added the Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. label May 15, 2025
@Batrachophreno
Copy link
Contributor Author

Alternatively, accessing wires could be something requiring an alt-click or ctrl-click. If the panel is open, alt- or ctrl- will show you the wires. If the panel is closed, the device will default to its standard alt- or ctrl-click behavior, if it has one.

The two windows opening at the same time is kind of annoying to me, tbh! I almost always only want to see one or the other, not both simultaneously.

hazelrat
hazelrat previously approved these changes May 19, 2025
@hazelrat hazelrat dismissed their stale review May 19, 2025 12:21

Accidental approval prior to review required tag.

@hazelrat
Copy link
Contributor

@Batrachophreno If this is intended to be reviewed, please mark it for review.

I think it's more intuitive for interfaces to open regardless of the in-hand tool, at least in the examples in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. WIP The PR is a work in progress and should not be reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants