Wires interface must require panel to be open #20764
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18299
Original bug report was for Air Alarms always displaying their wiring interface when interacted with, even when the maintenance panel was still closed.
I found a few other objects which also did not correctly check if wires were accessible before displaying the interface.
There also remains some inconsistency: some objects will always display the wire interface when clicked on with panel open, but others require you to have certain tools in hand too (wirecutter, multitool, etc.). Without them in-hand, they won't give you the wire UI. I'm indifferent to which option is better, but it should be made consistent. If someone feels at all strongly about having tools in-hand vs. not to see the interface, then I can also make that change with whatever the prevailing opinion is.