Skip to content

Allows you to have an account in debt in character setup. #20774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Greenjoe12345
Copy link
Contributor

@Greenjoe12345 Greenjoe12345 commented May 18, 2025

Adds some economic status levels, bankrupt (you spawn with no money at all), and several levels of debt.
(hopefully the sql migrate is alright?)

@github-actions github-actions bot added the Database The PR or issue affects the database. label May 18, 2025
@Greenjoe12345
Copy link
Contributor Author

!review

Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wont work as is.

The first issue is that changes to the account in one round are not persisted back to the database.
-> So even if someone could go into debt on their account, then this status would disappear after the current round.

From what I remember, the economy subsystem does not support debt at the moment.
-> Afaik there was a issue a few years ago where upon getting a account to a negative value, it basically allowed "unlimited" use.

In addition, if we want the economy subsystem to handle debt, considerations must be made for the department accounts. (As we wouldn't want those to be overdrawn)

@Greenjoe12345
Copy link
Contributor Author

Afaik there was a issue a few years ago where upon getting a account to a negative value, it basically allowed "unlimited" use.
I did do some testing with that, an account in the negatives didn't seem to allow for ATM withdrawals or purchases
And in terms of departmental accounts, it doesn't have a system of those to go into debt

@Greenjoe12345 Greenjoe12345 changed the title Debt stuff Allows you to have an account in debt in character setup. May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database The PR or issue affects the database. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants