Moves various things to the new DBCore#21544
Open
Arrow768 wants to merge 1 commit intoAurorastation:masterfrom
Open
Moves various things to the new DBCore#21544Arrow768 wants to merge 1 commit intoAurorastation:masterfrom
Arrow768 wants to merge 1 commit intoAurorastation:masterfrom
Conversation
Member
Arrow768
commented
Nov 3, 2025
Arrow768
commented
``` - server: "Changed the synthsprites to use the new DBCore" - server: "Changed the MalfAI to use the new DBCore" - server: "Changed the Alien Whitelists to use the new DBCore" - server: "Changed the Requests Console to use the new DBCore" - server: "Changed the Contracts Uplink to use the new DBCore" - server: "Changed the Admin Ranks to use the new DBCore" - server: "Changed the Job Bans to use the new DBCore" - server: "Changed the Tickets to use the new DBCore" - server: "Changed the Create Command Report to use the new DBCore" - server: "Changed the WebInterface interconnect to use the new DBCore" - server: "Changed the CCIA Recorder to use the new DBCore" - server: "Changed the IPCTags to use the new DBCore" - server: "Changed the Main Menu Poll-Check to use the new DBCore" - server: "Changed the Client-Procs to use the new DBCore" ```
FabianK3
requested changes
Nov 16, 2025
| return | ||
|
|
||
| var/DBQuery/Q = GLOB.dbcon.NewQuery({"INSERT INTO ss13_tickets | ||
| var/datum/db_query/query = SSdbcore.NewQuery({"INSERT INTO ss13_tickets |
Contributor
There was a problem hiding this comment.
Missing qdel of query, but I assume that's fine due to allow_during_shutdown=true?
| @@ -165,22 +165,24 @@ GLOBAL_LIST_EMPTY(ticket_panels) | |||
| if (!establish_db_connection(GLOB.dbcon)) | |||
| @@ -62,12 +62,13 @@ | |||
| if(GLOB.config.sql_ccia_logs) | |||
| return | ||
|
|
||
| var/DBQuery/query = GLOB.dbcon.NewQuery("SELECT datediff(Now(),firstseen) as age, whitelist_status, account_join_date, DATEDIFF(NOW(), account_join_date), ckey_is_external FROM ss13_player WHERE ckey = :ckey:") | ||
| var/datum/db_query/query = SSdbcore.NewQuery("SELECT datediff(Now(),firstseen) as age, whitelist_status, account_join_date, DATEDIFF(NOW(), account_join_date), ckey_is_external FROM ss13_player WHERE ckey = :ckey",list("ckey"=ckey(key))) |
Contributor
There was a problem hiding this comment.
Missing qdel for this query?
|
This pull request has been marked as stale due to the lack of activity within the last 60 days. If you are still working on this, please push your work or leave a comment. Pull requests marked as stale won't be auto-closed but are at the discretion of staff to be closed at any point without further notice. |
github-actions
bot
added
the
Stale
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.