fix: admin soft-delete should preserve memberships (AAI-607) #163
+69
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes admin soft-deletion to preserve user memberships to platforms and groups, allowing restored users to regain access immediately without waiting for Auth0 role synchronization (which could take ~30 minutes).
Changes:
- Added a
delete_membershipsparameter (defaultTrue) to theBiocommonsUser.delete()method to control whether memberships are deleted - Updated
admin_delete()to calldelete()withdelete_memberships=Falseto preserve memberships - Added comprehensive unit tests to verify the new behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| db/models.py | Added delete_memberships parameter to delete() method and updated admin_delete() to preserve memberships |
| tests/db/test_models.py | Added three new tests: test_admin_delete, test_admin_restore, and test_admin_delete_preserves_memberships to verify the new functionality |
amandazhuyilan
approved these changes
Jan 14, 2026
Contributor
amandazhuyilan
left a comment
amandazhuyilan
left a comment
There was a problem hiding this comment.
Looks good - let's test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AAI-607: soft-deletion should preserve memberships, so that after restoring, users can access platforms and bundles again immediately. (Users would regain access after their Auth0 roles were synced, but this could take ~30 minutes currently)
Changes