Skip to content

Conversation

@amandazhuyilan
Copy link
Contributor

@amandazhuyilan amandazhuyilan commented Jan 15, 2026

Description

AAI-620: updates AAI portal links in approval emails to be environment-aware, defaulting to dev/staging URLs and allowing overrides via settings.

Changes

  • Add ENVIRONMENT-based defaults for aai_portal_url in config.py
  • Normalize portal URLs (strip trailing slashes) and validate unknown environments
  • Add unit tests covering dev/staging defaults, override behavior, and invalid environment handling
  • .env file would need to be set as
ENVIRONMENT=dev # default
# or
ENVIRONMENT=staging

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

<Describe how reviewers can manually, if necessary, test the changes>

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@amandazhuyilan amandazhuyilan merged commit 1f035e3 into main Jan 15, 2026
5 checks passed
@amandazhuyilan amandazhuyilan deleted the AAI-620-fix-approval-email-urls branch January 15, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants