fix: using SecureRandom in perf tools #2420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om instead of ThreadLocalRandom
yannaingtun
requested review from
superhx,
SCNieh,
Chillax-0v0 and
Gezi-lzq
as code owners
|
Hi, thanks for your commit, however the purpose of using Random here is simply to generate non-repeatable topic names for benchmark test, so I don't think is neccessary to use a secure random generator here for there is no cryptographically need in this case |
|
|
daniel-y
changed the title
|
@yannaingtun could you please sign the CLA before merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential security vulnerability in the randomString method in PerfConfig.java by replacing ThreadLocalRandom with SecureRandom for generating random strings.
Issue
The current implementation uses ThreadLocalRandom which is not cryptographically secure and could lead to predictable tokens when used for security purposes.
Fix
Replace ThreadLocalRandom.current() with new SecureRandom() to ensure cryptographic strength.
References
Similar to vulnerability in CVE-2017-15911
Fixed in Openfire: igniterealtime/Openfire@7ff1f73