perf: Standardize ExecutorService Shutdown with Safety Wrapper. #2430
+13
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjust the memory settings in VM Options and change `-Xmx1` to `-Xmx1G` Signed-off-by: ZetoHkr <[email protected]>
- Introduce the ThreadUtils class to uniformly handle thread pool shutdown AutoMQ#2358
shawngao-org
requested review from
superhx,
SCNieh,
Chillax-0v0 and
Gezi-lzq
as code owners
shawngao-org
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2358
This is my first attempt at modification, please point out if there are any mistakes and I will continue to correct them.
(There may be some missing parts. ?)