Skip to content

fix: correctly use bytebuffer slice in decodecontexts method #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: correctly use bytebuffer slice in decodecontexts method #2925

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41bc358
fix: correctly use bytebuffer slice in decodecontexts method
brittytino Oct 7, 2025
d864004
Merge branch 'AutoMQ:main' into main
brittytino Oct 9, 2025
669053e
Merge branch 'AutoMQ:main' into main
brittytino Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions core/src/main/java/kafka/automq/failover/FailoverListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,15 @@ private Optional<FailoverContext[]> getContexts(MetadataDelta delta) {
.map(kv -> kv.get(FailoverConstants.FAILOVER_KEY))
.map(this::decodeContexts);
}

private FailoverContext[] decodeContexts(ByteBuffer byteBuffer) {
byteBuffer.slice();
byte[] data = new byte[byteBuffer.remaining()];
byteBuffer.get(data);
private FailoverContext[] decodeContexts(ByteBuffer byteBuffer) {
ByteBuffer slice = byteBuffer.slice();
byte[] data = new byte[slice.remaining()];
slice.get(data);
return JsonUtils.decode(new String(data, StandardCharsets.UTF_8), FailoverContext[].class);
}


private void onContextsChange(FailoverContext[] contexts) {
Set<FailedNode> oldFailedNodes = recovering.keySet();
Set<FailedNode> newFailedNodes = Arrays.stream(contexts)
Expand Down
Loading