Issue #144: 2D cylinder flow example and a bug fix resolving prescribed_value/values discrepancy

[tgautam03]

Contributing Guidelines

• [ x] I have read and understood the CONTRIBUTING.md guidelines

Description

Contributing an example involving flow around a 2D cylinder with FullwayBounceBackBC and ZouHeBC. While writing this example, I found an inconsistency in the class ZouHeBC. During initialization it accepts prescribed_value, while the methods get_rho, get_vel use self.prescribed_values.

I have updated the class ZouHeBC such that it accepts prescribed_values during initialization and have made the changes appropriately (changing prescribed_value to prescribed_values wherever required).

Type of change

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

This is a small bug fix and I tested it by running 2D cylinder flow for multiple resolutions.

Linting and Code Formatting

Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.

To run Ruff, execute the following command from the root of the repository:

ruff check .

• [ x] Ruff passes

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[tgautam03]

I have read the CLA Document and I hereby sign the CLA

[tgautam03]

recheck

[mehdiataei]

Hi @tgautam03 thanks for your contribution. The BCs can take many values (e.g. a distribution) so it's not a single value, hence the naming.

[tgautam03]

@mehdiataei Did I miss something here? I wasn't able to use ZouHeBC unless I declare prescribed_values explicitly. Please let me know if the changes I made to the class were not necessary or incorrect in any way.

[mehdiataei]

Please see the windtunnel_3d example (you can change the BC from regularized to ZouHe and it still works fine with the current implementation)