Use a single display driver for all AOVs in the render delegate #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Instead of creating one display driver (driver_aov) for each AOV, I'm using the "main driver" which is already used for beauty, position, and id.
For that I'm adding 2 array attributes, for the AOV names and the buffer pointers.
In
driver_process_bucket, as we iterate over the output results, based on the AOV name we pass the data to the corresponding buffers.This makes it much more interactive for scenes having imagers and a lot of AOVs
Issues fixed in this pull request
Fixes #2284