Optionally use Hydra Render Settings primitive instead of settings map #2651
Open
sebastienblor wants to merge 2 commits into
Open
Optionally use Hydra Render Settings primitive instead of settings map #2651sebastienblor wants to merge 2 commits into
sebastienblor wants to merge 2 commits into
Conversation
Collaborator
Author
|
Here I'm making it so that the hydra2 testsuite uses the new code path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR removes the ifdefs around ENABLE_HYDRA2_RENDERSETTINGS and instead makes it an optional code path triggered by a specific value
renderSettingsSrcbeing set tohydraSceneRenderSettingsSrc. This setting is specific to MayaHydra which is currently the only tool expecting render delegates to use the render settings primitive, but it can be extended later on to other tools if neededIssues fixed in this pull request
Fixes #2650