Skip to content

Remove call to path interface from pruning scene index. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilike-adsk merged 1 commit into from
Jan 14, 2025
Merged

Remove call to path interface from pruning scene index. #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/flowViewport/sceneIndex/fvpPruningSceneIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ class PruningSceneIndex :
FVP_API
PrimSelections UfePathToPrimSelections(const Ufe::Path& appPath) const override {
PXR_NAMESPACE_USING_DIRECTIVE;
const PathInterface* pathInterface = dynamic_cast<const PathInterface*>(&*GetInputSceneIndex());
TF_AXIOM(pathInterface);
return pathInterface->UfePathToPrimSelections(appPath);

TF_FATAL_ERROR("Illegal call to deprecated %s", TF_FUNC_NAME().data());

return PrimSelections();
Copy link
Collaborator

@lilike-adsk lilike-adsk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we remove this API if it's not expected to used?

Copy link
Collaborator Author

@ppt-adsk ppt-adsk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is in followon tremblp/HYDRA-1060/tech_debt_remove_path_interface_1 branch, ready to go.

}

protected:
Expand Down