Skip to content

Comments

HYDRA-1821 : Fix MSAA with 2 passes#349

Merged
debloip-adsk merged 19 commits intodevfrom
debloip/HYDRA-1821/fix-msaa-2-passes
Nov 21, 2025
Merged

HYDRA-1821 : Fix MSAA with 2 passes#349
debloip-adsk merged 19 commits intodevfrom
debloip/HYDRA-1821/fix-msaa-2-passes

Conversation

@debloip-adsk
Copy link
Collaborator

@debloip-adsk debloip-adsk commented Nov 20, 2025

In this PR :

  • Update to latest HVT & adjust our rendering code very slightly to fix MSAA
  • Remove all the "two_passes" images that were added to deal with the MSAA not working
  • Re-baseline new & old reference images for MSAA (& USD 25.08 in some cases)
  • Fix testFramePasses reference images (looks like the previous reference images had incorrect results and it works now)

@debloip-adsk debloip-adsk marked this pull request as ready for review November 21, 2025 14:54
@debloip-adsk debloip-adsk self-assigned this Nov 21, 2025
cmds.refresh()

self.setBasicCam(1)
self.EnablePassesOneByOneAndDoSnapshots(name="FootPrintAsScndGraphics", failures=failures, useDynamicVersion=True)#Is dependent on the number of frame passes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new baselines for this case look different is because the old baselines were located at "two_passes" folder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that makes sense, good catch thanks

Copy link
Collaborator

@lilike-adsk lilike-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean up!

@debloip-adsk debloip-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 21, 2025
@debloip-adsk debloip-adsk merged commit 2395fb0 into dev Nov 21, 2025
10 checks passed
@debloip-adsk debloip-adsk deleted the debloip/HYDRA-1821/fix-msaa-2-passes branch November 21, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Development process is finished, PR is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants