HYDRA-1993 : Fix Maya lights crash when using HdArnold#352
Merged
debloip-adsk merged 2 commits intodevfrom Nov 28, 2025
Merged
Conversation
debloip-adsk
commented
Nov 27, 2025
| return bbox; | ||
| } | ||
|
|
||
| const SdfPath& MayaHydraSceneIndex::MayaDefaultLightPath() |
Collaborator
Author
There was a problem hiding this comment.
We need to access this before the first MayaHydraSceneIndex is created, and this is essentially a static constant anyways, so I extracted the data field into a static variable inside the static method, so we don't need to have created a MayaHydraSceneIndex to use the value.
Collaborator
Author
There was a problem hiding this comment.
This adds a Maya area light and a USD distant light
lanierd-adsk
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the crash happened :
So if we select Arnold, then shadow data is generated, and the secondary pass with Storm receives this shadow data but does not support it : crash
This fix adds the option in pass filtering to remove lights from a pass, which we do in the secondary pass, whilst keeping only the Maya default light (which is a simple light, so no issues there)