Skip to content

Conversation

@lilike-adsk
Copy link
Collaborator

Fix build errors for usd 25.11

currentPass->params().backgroundColor = GfVec4f(0.0f, 0.0f, 0.0f, 0.0f);//For clearing
currentPass->params().backgroundDepth = 1.0f;//For clearing
currentPass->params().renderParams.enableLighting = true;
#if PXR_VERSION <= 2508
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enableSceneMaterials is deprecated in 25.11

#include <windows.h>
// interface was used as variable name in materialNetworkSchema.h
// but defined as struct in basetyps.h included by windows.h, undefine it here to avoid conflicts
#undef interface
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, Hydra code should avoid to use interface as variable name, not sure is there any better way to fix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing this before, and had the same fix. Can't find the code any more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, tried Cursor, no better way

@lilike-adsk lilike-adsk requested a review from ppt-adsk December 17, 2025 18:56
@lilike-adsk lilike-adsk self-assigned this Dec 17, 2025
#if defined(_WIN32)
#include <windows.h>
// interface was used as variable name in materialNetworkSchema.h
// but defined as struct in basetyps.h included by windows.h, undefine it here to avoid conflicts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basetyps.h looks like a typo...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include <windows.h>
// interface was used as variable name in materialNetworkSchema.h
// but defined as struct in basetyps.h included by windows.h, undefine it here to avoid conflicts
#undef interface
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing this before, and had the same fix. Can't find the code any more.

@lilike-adsk lilike-adsk merged commit 79c9f7d into dev Dec 17, 2025
10 checks passed
@lilike-adsk lilike-adsk deleted the lilike/HYDRA-2013/fix-build-errors-for-usd-25-11 branch December 17, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants