Allow passing image writer object to image write method. #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Dec 17, 2025
| } | ||
|
|
||
| /* static */ | ||
| bool ImageBufferWriter::Write( |
Collaborator
Author
There was a problem hiding this comment.
The ImageBufferWriter::Create() factory method is not flexible enough to support all the modes required by the proof of concept work (e.g. with and without frame pass). By exposing a method that allows directly passing in the writer object, it can be created outside the image writer framework to adapt to requirements.
lanierd-adsk
previously approved these changes
Dec 18, 2025
lanierd-adsk
approved these changes
Dec 18, 2025
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in proof of concept work.