EMSUSD-2278 - Creating or parenting a camera under a USD def will crash Maya #4177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
requested changes
Apr 2, 2025
There was a problem hiding this comment.
There should be a new unit test that does exactly what the JIRA item says. Test which creates a camera under a def. Please add the test first without this change and verify that the test fails (it should crash). Then add your new fix and the test should pass.
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-2278/create_camera_under_def_crash
branch
2 times, most recently
from
cb5d89a to
ea73072
Compare
samuelliu-adsk
commented
Apr 4, 2025
| self.assertSnapshotClose('%s_invisibile.png' % (self._testName)) | ||
| object3d.setVisibility(True) | ||
| self.assertSnapshotClose('%s_visibile.png' % (self._testName)) | ||
|
|
There was a problem hiding this comment.
Added camera creation under scope and def. Also added tests to test camera visibility if its parent is set to invisible
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-2278/create_camera_under_def_crash
branch
from
ea73072 to
7e3c3ff
Compare
|
My commit history is totally messed up.. Will create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.