Integrate the component manager #4386
Conversation
| bool isAdskUsdComponent(const std::string& proxyShapePath) | ||
| { | ||
| MString defineIsComponentCmd; | ||
| defineIsComponentCmd.format( |
There was a problem hiding this comment.
Not for now, but I think we should eventually refactor all those Python functions into a "helper" sub-module of usd_component_creator and avoid redefining and reparsing these functions all the time. (Merged with Anthon's)
pierrebai-adsk
left a comment
pierrebai-adsk
left a comment
There was a problem hiding this comment.
Just a few minor improvements.
…t_show_more_preview' into deboisj/comp_mgr # Conflicts: # lib/usd/ui/layerEditor/layerTreeModel.cpp
| } | ||
| } | ||
|
|
||
| std::string previewSaveAdskUsdComponent( |
There was a problem hiding this comment.
Code moved from what Anton merged. I just changed double quotes to quotes in the inlined python
| const auto result = MayaUsd::ComponentUtils::previewSaveAdskUsdComponent( | ||
| saveLocation, componentName, _proxyShapePath.c_str()); | ||
|
|
||
| QString jsonStr = QString::fromStdString(result); |
There was a problem hiding this comment.
No changes starting here.
| " stage = mayaUsd.ufe.getStage(\"^1s\")\n" | ||
| " if stage is None:\n" | ||
| " return \"\"\n" | ||
| " ids = MayaComponentManager.GetInstance().GetSaveInfo(stage)\n" |
There was a problem hiding this comment.
can this fail? if so maybe we need to add validation on the evaluation and reporting that error occured.
There was a problem hiding this comment.
(answer offline) the only thing that can fail is if the CC isnt present or the path isnt a component path - but this function documents expecting a valid component path - and this is made sure of before calling into this one. So any such error would be reported from "above"
deboisj
added
the
ready-for-merge
Special handling of Save() and the overwrite prompt when dealin with Adsk USD Components.