Added BOOST_NS=PXR_NS::pxr_boost for Asset Resolver #4388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autodesk Asset Resolver requires this definition to compile. BOOST_NS=PXR_INTERNAL_NS::pxr_boost
brossee-adsk
previously approved these changes
Dec 2, 2025
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Dec 2, 2025
|
|
||
| target_compile_definitions(${PROJECT_NAME} | ||
| PRIVATE | ||
| BOOST_NS=PXR_INTERNAL_NS::pxr_boost |
Collaborator
There was a problem hiding this comment.
Does this need to be PXR_INTERNAL_NS? Would PXR_NS work instead?
Collaborator
Author
There was a problem hiding this comment.
@seando-adsk replaced it with PXR_NS . It seems to compile fine locally.
seando-adsk
approved these changes
Dec 2, 2025
brossee-adsk
approved these changes
Dec 2, 2025
AramAzhari-adsk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodesk Asset Resolver requires this definition to compile. BOOST_NS=PXR_NS::pxr_boost