Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests & Documentation #1095

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Unit Tests & Documentation #1095

merged 8 commits into from
Aug 21, 2024

Conversation

LucaHaverty
Copy link
Contributor

@LucaHaverty LucaHaverty commented Aug 15, 2024 •
edited
Loading

Description

Unit tests for the major systems that I worked on this summer

Objectives

  • Input System Tests
  • Preferences System Tests
  • Select Menu Tests
  • Lots of documentation

@LucaHaverty LucaHaverty self-assigned this Aug 15, 2024
@LucaHaverty LucaHaverty changed the title Haverty/unit tests Unit Tests Aug 15, 2024
@LucaHaverty LucaHaverty marked this pull request as ready for review August 19, 2024 16:46
@LucaHaverty LucaHaverty requested review from HunterBarclay and a team as code owners August 19, 2024 16:46
@LucaHaverty LucaHaverty requested review from a-crowell and Dhruv-0-Arora and removed request for a team August 19, 2024 16:46
@LucaHaverty LucaHaverty changed the title Unit Tests Unit Tests & Documentation Aug 20, 2024
@LucaHaverty LucaHaverty marked this pull request as draft August 20, 2024 17:53
@LucaHaverty LucaHaverty marked this pull request as ready for review August 20, 2024 20:36
@LucaHaverty LucaHaverty requested a review from a team as a code owner August 20, 2024 20:36
@LucaHaverty LucaHaverty requested review from PepperLola and azaleacolburn and removed request for a team August 20, 2024 20:36
azaleacolburn
azaleacolburn approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super Cool!

BrandonPacewic
BrandonPacewic approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 🪺

Dhruv-0-Arora
Dhruv-0-Arora approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid!

@BrandonPacewic BrandonPacewic merged commit b813e13 into dev Aug 21, 2024
14 checks passed
@BrandonPacewic BrandonPacewic deleted the haverty/unit-tests branch August 21, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaleacolburn azaleacolburn azaleacolburn approved these changes

@BrandonPacewic BrandonPacewic BrandonPacewic approved these changes

@Dhruv-0-Arora Dhruv-0-Arora Dhruv-0-Arora approved these changes

@HunterBarclay HunterBarclay Awaiting requested review from HunterBarclay HunterBarclay is a code owner

@a-crowell a-crowell Awaiting requested review from a-crowell a-crowell is a code owner automatically assigned from Autodesk/fission

@PepperLola PepperLola Awaiting requested review from PepperLola PepperLola was automatically assigned from Autodesk/synthesis-devs

Assignees

@LucaHaverty LucaHaverty

Labels
documentation testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaHaverty @azaleacolburn @BrandonPacewic @Dhruv-0-Arora