Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing Cached From Map Hotfix #1098

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Importing Cached From Map Hotfix #1098

merged 8 commits into from
Aug 21, 2024

Conversation

a-crowell
Copy link
Contributor

@a-crowell a-crowell commented Aug 19, 2024 •
edited by BrandonPacewic
Loading

Description

Mirabuf files imported from the hashmap would fail to load.

Objectives

  • Load in mirabuf files from hash map
  • Removed unused panel
  • Fixed generation bug

Testing

  • Forcing hashmap usage on Windows PC
  • Safari/Apple Mobile

@a-crowell a-crowell requested review from HunterBarclay and a team as code owners August 19, 2024 23:19
@a-crowell a-crowell requested review from LucaHaverty and Dhruv-0-Arora and removed request for a team August 19, 2024 23:19
@a-crowell a-crowell self-assigned this Aug 20, 2024
@a-crowell a-crowell added the hotfix Pull requests that should be resolved before the next snapshot/release label Aug 20, 2024
@BrandonPacewic BrandonPacewic self-requested a review August 21, 2024 18:55
BrandonPacewic
BrandonPacewic reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirabuf files imported from the hashmap would fail to load.

Any steps to reproduce this bug on dev?

@a-crowell
Copy link
Contributor Author

a-crowell commented Aug 21, 2024 •
edited
Loading

Mirabuf files imported from the hashmap would fail to load.

Any steps to reproduce this bug on dev?

On Safari or iOS, try to load a cached mirabuf object.

Dhruv-0-Arora
Dhruv-0-Arora requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Ayla about this: currently on Safari it logs to console "No access to OPFS" and quits without any errors.

@BrandonPacewic BrandonPacewic self-requested a review August 21, 2024 21:56
BrandonPacewic
BrandonPacewic approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on safari now. Woooooo! 🎊

Dhruv-0-Arora
Dhruv-0-Arora approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resplendent

@BrandonPacewic BrandonPacewic merged commit 1da19af into dev Aug 21, 2024
14 checks passed
@BrandonPacewic BrandonPacewic deleted the crowela/map-caching-panel branch August 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonPacewic BrandonPacewic BrandonPacewic approved these changes

@Dhruv-0-Arora Dhruv-0-Arora Dhruv-0-Arora approved these changes

@HunterBarclay HunterBarclay Awaiting requested review from HunterBarclay HunterBarclay is a code owner

@LucaHaverty LucaHaverty Awaiting requested review from LucaHaverty LucaHaverty is a code owner automatically assigned from Autodesk/fission

Assignees

@a-crowell a-crowell

Labels
bug hotfix Pull requests that should be resolved before the next snapshot/release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-crowell @BrandonPacewic @Dhruv-0-Arora