Refactor Mirabuf Loading System [AARD-2060]#1273
Merged
PepperLola merged 28 commits intodevfrom Aug 21, 2025
Merged
Conversation
azaleacolburn
approved these changes
Aug 14, 2025
5 tasks
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
edf84e2 to
91d228d
Compare
fix: try to make unit tests work fix: actually make unit tests work feat: add unit tests for default assets fix: tsconfig issues again
91d228d to
edee81d
Compare
PepperLola
requested changes
Aug 20, 2025
2998126 to
e7bb1e1
Compare
Co-authored-by: Julian Wright <PepperLola@users.noreply.github.com>
Co-authored-by: Julian Wright <PepperLola@users.noreply.github.com>
Member
Author
|
BrandonPacewic
approved these changes
Aug 21, 2025
Member
BrandonPacewic
left a comment
There was a problem hiding this comment.
I understand we are try to fix the workflow. Everything other than that looks good to me. Waiting for final changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task
AARD-2060 - Refactor mirabuf caching service
AARD-2069 - Make uploading local mirabuf files enforce correct miratype (with gamepieces we can't just infer miratype completely)
Symptom
The current MirabufCachingService made a few decisions that made it hard to understand and had some key limitations:
idfield was unique but not consistent (it was based on the time that you first downloaded the file to your cache). This was the impetus for changing this, as we needed consistent IDs for multiplayer.cacheKeyfield was either the name of the APS project, the remote download URL, or the hash of the locally uploaded fileMirabufCacheInfotype was used both to store information about the OPFS files and to store in-memory references to the ArrayBuffersSolution
idfield has been replaced with ahashfield, that is the SHA-1 hash of the assembly (consistent and unique)name), and there is a single source of truth for asset metadataVerification
Note
Your mirabuf cache will be cleared every time you switch between Synthesis on this branch and Synthesis not on this branch
Before merging, ensure the following criteria are met: