Shadow Dom GetHtml and Retry Logic Update #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hadowRoot - due to changes in inShadowContext() method, the getHtml never returns the actual shadow dom html if the element is ShadowRoot
As per the logic in Selenium: - It is a valid case to return an empty list of components - the user should add retry logic to createAll if they intend to wait for some element to appear - the user should write themselves logic to throw an exception if finding 0 elements is unacceptable - an exception should be thrown in case one searches for 1 element and it is not found after retrying for the specified time - the user should try-catch if it happens to be a valid case to not find any element matching the locator
n1xan
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getHtmlstopped returning the actual shadow dom html in case the current element isShadowRoot; fixedcreateAll(searching for multiple elements) was moved tocreate(searching for only one element), as it is a valid case to return a list of 0 elements. Furthermore retrying for a specified time and throwing an exception after that if no element was found is valid forcreate