Added extras project, added Services hooks and added onError listener for all hooks #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
teo-nikolov
commented
Jan 29, 2025
teo-nikolov
commented
- Added extras project for default listeners and plugins
- Added hooks for WebService classes
- Added onError listener for all hooks
- Removed unnecessary retry in web components, single handling of StaleElementError seems enough
- Renamed BrowserAutomationTool to BrowserController
- Moved BrowserAutomationToolLifecycleService to infrastructure and renamed it to BrowserControllerLifecycleManager
- Updated imports for all the affected files
- Fixed minor type error
… added services hooks and added onError hook
n1xan
reviewed
Jan 29, 2025
| }, | ||
| after<Key extends AsyncMethods<TComponent>>(methodName: Key, method: (componentInstance: TComponent, ...args: Parameters<TComponent[Key] extends (...args: infer _P) => infer _R ? TComponent[Key] : never>) => unknown) { | ||
| } | ||
|
|
n1xan
approved these changes
Jan 29, 2025
Collaborator
n1xan
left a comment
n1xan
left a comment
There was a problem hiding this comment.
Approved with a small comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.