Skip to content

adapt to python changes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adapt to python changes #27

wants to merge 2 commits into from

Conversation

@yogo1212
Copy link
Contributor

No description provided.

@yogo1212 yogo1212 mentioned this pull request Jan 21, 2019
Merged
@ahelal
Copy link
Member

ahelal commented Jan 21, 2019

Hey @yogo1212
Sorry I must of missed this.

is this backward compatible with 2.7 ?

@yogo1212
Copy link
Contributor Author

yogo1212 commented Jan 21, 2019 •
edited
Loading

@ahelal in 2.7, items() will copy the values (slower) but should be functionally compatible, otherwise.
https://docs.python.org/2.7/library/stdtypes.html#dict.items
https://docs.python.org/3/library/stdtypes.html#dict.items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yogo1212 @ahelal