Allow consumers to delegate release name creation to the SDK #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6de0efb.
BREAKING CHANGE: `CrashLoggingDataProvider#releaseName` changed its type from `String` to `ReleaseName`
wzieba
force-pushed
the
allow-sentry-created-release-name
branch
from
5ae8f27 to
8ae5a45
Compare
1 task
Member
Author
|
hi @crazytonyli ! Friendly ping in case if you missed this PR, does it look good to you? (also iOS PR: Automattic/Automattic-Tracks-iOS#285) |
crazytonyli
approved these changes
Mar 26, 2024
Contributor
crazytonyli
left a comment
crazytonyli
left a comment
There was a problem hiding this comment.
Thanks for making the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main discussion: #204
Description
This PR introduces a possibility for SDK consumers to delegate defining a release name to the Tracks library (eventually - to Sentry SDK).
This is a way to address an issue of incorrectly assigning release names between projects in the same Sentry organization.