Add id and user type to store formatted author data #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Merged
6 tasks
leogermani
reviewed
Apr 10, 2025
src/utils.js
Outdated
| @@ -72,8 +72,9 @@ export const addItemByValue = ( | |||
| * | |||
| * @return {Object} The object containing data relevant to the Coauthors component. | |||
| */ | |||
| export const formatAuthorData = ( { displayName, userNicename, email } ) => { | |||
| export const formatAuthorData = ( { id, displayName, userNicename, email } ) => { | |||
There was a problem hiding this comment.
need to also update the docblock
miguelpeixe
changed the title
6 tasks
leogermani
approved these changes
Apr 14, 2025
|
@GaryJones we need this tiny change for something that we are releasing soon on Newspack. Any concerns if I spin up a new version with it? |
Merged
|
Thanks, @GaryJones! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the author ID and user type to the store's formatted data. This is useful for 3rd parties that need to read from the edited post authors' data.
Usage example: Automattic/newspack-plugin#3906
Deploy Notes
Just a js build.
Steps to Test
There should be no impact on the plugin behavior. Make sure the "Authors" panel continues to work as expected.