Ported over the maybe_change_filter_position() in Synonyms from the 10up ElasticPress codebase#230
Open
petenelson wants to merge 1 commit intoAutomattic:developfrom
Open
Conversation
…0up ElasticPress codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ep_synonyms_filter in the index settings is being added first before the lowercase filter, causing case-sensitive matching to applied to synonyms. Using the
_settingsendpoint on the ES index is showing this:when it should be showing this
This has been fixed in the 10up ElasticPress codebase. https://github.com/10up/ElasticPress/blob/develop/includes/classes/Feature/Search/Synonyms.php#L895
Checklist
Please make sure the items below have been covered before requesting a review:
Steps to Test