Fix warning for case of non-existing 'post_type' key in query vars#231
Open
econscript wants to merge 2 commits intodevelopfrom
Open
Fix warning for case of non-existing 'post_type' key in query vars#231econscript wants to merge 2 commits intodevelopfrom
econscript wants to merge 2 commits intodevelopfrom
Conversation
…_var parameter on certain queries
Author
|
I had to pull in this upstream commit to fix the Unit tests: 10up#2984 The rest of this method was updated in this PR: https://github.com/Automattic/ElasticPress/pull/228/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pulls a fix made upstream: 10up#4105
Silences a noisy
Undefined array key "post_type"PHP warning whenever a query is made without thepost_typeparameter in thequery_varsarray.Checklist
Please make sure the items below have been covered before requesting a review:
Steps to Test