-
Notifications
You must be signed in to change notification settings - Fork 31
Add workaround to distribute prototype build in synchronized folder Xcode setup #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround to distribute prototype build in synchronized folder Xcode setup #681
Conversation
Just a routine update before digging deeper into a build failure, see https://buildkite.com/automattic/gravatar-sdk-ios/builds/2135/steps?sid=0195d364-32bb-47c4-a10c-0da0a39806ce
473aa49 to
063ab27
Compare
|
|
||
| desc 'Builds the Gravatar-Demo project with a specific scheme' | ||
| lane :build_demo do |scheme: 'Gravatar-Demo'| | ||
| lane :build_demo do |scheme: 'Gravatar Demo'| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but I noticed the scheme name here was outdated.
|
| App Name | ||
| Build Number | 2146 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | c796623 | |
| App Center Build | Gravatar SDK Demo - UIKit #614 |
AliSoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some more links to fastlane issue and Xcodeproj PR to document this even more. Otherwise LGTM.
I'm hoping I'll be able to find some time next week to work on the fastlane codebase and fix that (either land PRs that might fix it already, or fix it myself otherwise + look at other Xcode 16-related PRs…) before doing a new version of fastlane.
No promises about the timeline though, so in the meantime I'm all good with going with this workaround.
|
Thank you for sorting this! I am more than happy to merge this and then follow up later with an update to fastlane + removing this workaround. |
Co-authored-by: Olivier Halligon <[email protected]>
|
For posterity, we can revert these commits when fastlane is updated to handle this properly. We can leave commit |
2bffa51
into
andrewdmontgomery/Demo-convert-groups-to-folders
Somehow, switching to Xcode synchronized folders broke Fastlane's ability to generate the
export_optionsautomatically.As a workaround, we can specify them manually for the time being.
See:
For the record, I also tried removing the
PROVISIONING_PROFILE_SPECIFIERdefinition inEnterprise.xcconfig. The releasexcconfigoverrides it, but I thought that maybe the new Xcode setup interfered with Fastlane.Gravatar-SDK-iOS/Demo/Demo/Enterprise.xcconfig
Lines 7 to 15 in 6c22d6c
Unfortunately, it did not change the build outcome.