-
Notifications
You must be signed in to change notification settings - Fork 31
UIKit sheet presentation from SwiftUI context #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent them to be overridden by a custom URLSession
|
| App Name | Gravatar Prototype Build | |
| Build Number | 2387 | |
| Version | PR #763 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 12ce401 | |
| Installation URL | 1qmh5rjrgkc4o |
pinarol
reviewed
May 27, 2025
| ZStack { | ||
| content | ||
| quickEditorPresenter | ||
| .frame(width: 0, height: 0) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the trick! 🪄
pinarol
approved these changes
May 28, 2025
Contributor
pinarol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Masterpiece 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Closes BETS-50
Description
This PR is aimed to replace the native SwiftUI sheet presentation with the UIKit sheet presentation.
Wins from this changes are:
To Achieve this the follow changes were made:
QuickEditorViewControlleris now used by both UIKit and SwiftUI contexts. It wrapsQuickEditorview in aUIHostingControllerto be presented by UIKit framework.From UIKit context:
Not many changes. It uses the public
QuickEditorPresenterto presentQuickEditorViewControllerin a bottom sheet.A change was made where the
CustomImageEditorControllerRepresentableconversion is handled byQuickEditorPresenterdirectly, in order to remove UIKit dependencies from theQuickEditorViewControllerinit parameters.From SwiftUI context:
There's a new
QuickEditorBottomSheetPresenterViewControllerwhich will present modally (on a sheet) theQuickEditorViewController. This part is the trick to do the presentation work.Then
QuickEditorBottomSheetPresenterViewControllerRepresentablewraps it in a Representable, to be able to be inserted into the SwiftUI hierarchy.Then,
QuickEditorBottomSheetPresenterViewControllerRepresentableis initialised with the properties given by the publicView.gravatarQuickEditorSheetextension, and passed to a new view modifierQuickEditorBottomSheetViewControllerPresentationModifier.The new
QuickEditorBottomSheetViewControllerPresentationModifiermodifier will conditionally add or remove the presenter controller to the hierarchy according toisPresentedproperty. And it will ensure that its dimensions are zero to keep it hidden. Every time the controller is added to the hierarchy, it will automatically present the QuickEditorController in a sheet presentation.Testing Steps
From SwiftUI context:
From UIKit context:
Keen eye to:
As the rest has been mostly kept as it was before, but still good to smoke test everything else.