The edit button's fade away animation looks a bit glitchy #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent it to be hidden behind the avatar before it completely fades
pinarol
added
Bug
etoledom
approved these changes
May 28, 2025
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Perfect!
Thank you for this fix 🙏
|
| App Name | Gravatar Prototype Build | |
| Build Number | 2389 | |
| Version | PR #766 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 02e6858 | |
| Installation URL | 4rqlcrt2f3l08 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GRA-122
The edit button's fade away animation looks a bit glitchy, it hides behind the avatar before fully fading away.
ScreenRecording_05-28-2025.13-11-13_1.MP4
Description
When the button is fading away there's a point where SwiftUI decides to degrade it in the ZStack hierarcy so it gets hidden behind the avarar before completely fading.
Setting its zIndex prevents it to be hidden behind the avatar before it completely fades.
Testing Steps
The animation issue displayed in the video should be fixed.