Skip to content

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented May 29, 2025

Closes GRA-124

Description

This PR is meant to disable the About editor fields while the save request is ongoing.

I tried changing the style of the fields for a visual feedback but there's an issue with the text TextEditor on pre-iOS16

To be able to remove this white background from the text on pre-iOS16, we need to call:
UITextView.appearance().backgroundColor = .clear

Which doesn't seem good to do from an external library.

Testing Steps

  • Open the Quick Editor with About editor scope
  • Save some changes
    • Check that the fields are disabled while the request is ongoing.

@wpmobilebot
Copy link

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2393
VersionPR #768
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit21a9f6d
Installation URL6gm0t9gvv8b70
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@etoledom etoledom merged commit 5d838f6 into release/3.4.0 May 29, 2025
9 of 12 checks passed
@etoledom etoledom deleted the etoledom/disable-fields-on-save branch May 29, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants