Skip to content

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Jul 1, 2025

Closes GRA-439

Description

On this PR we deprecate AvatarSelection in favor of AvatarUploadSelectionPolicy.

The reason being AvatarSelection requires an Email, which is not always available, specially when authenticating through OAuth. AvatarUploadSelectionPolicy requires ProfileIdentifier which can be instantiated with an Email or a Email Hash. The hash can be retrieved directly from the Profile object.

Testing Steps

  • Smoke test Image upload demo screen
  • Smoke test uploading avatars in the Quick Editor demo

@wpmobilebot
Copy link

wpmobilebot commented Jul 1, 2025

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2451
VersionPR #792
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit356d43d
Installation URL3p80k2h8e1638
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@etoledom etoledom self-assigned this Jul 3, 2025
@etoledom etoledom added the Enhance New feature or request label Jul 3, 2025
@etoledom etoledom requested a review from pinarol July 3, 2025 06:02
@etoledom etoledom marked this pull request as ready for review July 3, 2025 06:02
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good 🎉

@etoledom etoledom merged commit 342e40c into trunk Jul 3, 2025
8 checks passed
@etoledom etoledom deleted the etoledom/image-upload-option-profile-id branch July 3, 2025 10:06
@pinarol pinarol restored the etoledom/image-upload-option-profile-id branch July 8, 2025 13:05
@pinarol pinarol deleted the etoledom/image-upload-option-profile-id branch July 8, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhance New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants