Add a connect timeout explicitly to hyperdb. #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same effect as the default_socket_timeout ini setting, but hopefully in future PHPs it would apply to the whole handshake.
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
You are correct - that change doesn't do anything without a bug fix on the PHP side which we have on WP.com/WP.org. There is a pull requests pending here: php/php-src#9532 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a connect timeout explicitly to wpdb. While this generally has the same effect as the default_socket_timeout ini setting, but hopefully in future PHPs it would apply to the whole handshake.
While upgrading HyperDB on WordPress.org, I spotted that we have a customization on WordPress.org & WordPress.com that hasn't been added to HyperDB on GitHub.
It initially appears that this might be a bugfix that doesn't apply to HyperDB directly with currently released versions of PHP, but as I can't see any harm in upstreaming this, and can't find any open PHP Bugs seemingly related to it, I'm PR'ing it here for reference and determinations.
@vnsavage I've requested review from you as you're the original author. Is this something that is safe to merge to HyperDB? Or should it be kept as a customization on the platforms?