Flush the query results variables following strip_invalid_text_from_query() #130
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery() to ensure queries from that function does not get returned to the caller function. This merges https://core.trac.wordpress.org/changeset/31093 to HyperDB.
|
Kudos, SonarCloud Quality Gate passed!
|
hj-collab
added a commit
to hj-collab/HyperDB
that referenced
this pull request
May 31, 2023
…d_text_from_query() Automattic#130
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush the query results variables following strip_invalid_text_from_query() to ensure queries from that function does not get returned to the caller function.
This changeset to wpdb was never added to to HyperDB.
18 months ago I merged it to our HyperDB on WordPress.org, but appear to have failed to create a PR here, and don't recall what I was fixing at the time. It appears it was likely causing PHP Notices somehow or causing problems in the WordPress.org stats.
Based on the core bug it was fixing, it appears it may also affect some unit tets.
@pento I don't suppose you recall any details of the above changeset, and if/why/not it should be added to HyperDB too?