Support SELECT DISTINCT SQL_CALC_FOUND_ROWS
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd32
commented
May 14, 2024
| @@ -969,7 +969,7 @@ public function query( $query ) { | |||
| $elapsed = $this->timer_stop(); | |||
| ++$this->num_queries; | |||
|
|
|||
| if ( preg_match( '/^\s*SELECT\s+SQL_CALC_FOUND_ROWS\s/i', $query ) ) { | |||
| if ( preg_match( '/^\s*SELECT\s+(DISTINCT\s+)?SQL_CALC_FOUND_ROWS\s/i', $query ) ) { | |||
There was a problem hiding this comment.
If we want to be more strictish and support other query modifiers, this would work:
Suggested change
| if ( preg_match( '/^\s*SELECT\s+(DISTINCT\s+)?SQL_CALC_FOUND_ROWS\s/i', $query ) ) { | |
| if ( preg_match( '/^\s*SELECT\s+([A-Z_]+\s+)*SQL_CALC_FOUND_ROWS\s/i', $query ) ) { |
Eg; SELECT SOME_MODE DISTINCT SQL_CALC_FOUND_ROWS * FROM...
JJJ
added a commit
to stuttter/ludicrousdb
that referenced
this pull request
Jun 18, 2024
Ported from HyperDB. See: Automattic/HyperDB#137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
The MariaDB SELECT format is...
The current regular expression therefor doesn't match any of the other query modifiers either, but
DISTINCTis AFAIK the only one that WordPress would be using.