Fix: Ensure $db['read'] and $db['write'] are defined in add_database #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Ensure $db read/write keys are defined in add_database
The HyperDB::add_database function was potentially exiting with undefined
'$read' and '$write' variables if they were not passed in the initial
configuration array.
This occurs because:
1. The function uses an 'extract' call (line ~519 in the calling context)
which may not define '$read' or '$write'.
2. The logic to set $read/$write defaults only runs *if* the variable
is not set (e.g., `if ( ! isset( $read ) ) { $read = 1; }`).
3. If the variable is *not* defined at all (as opposed to being defined
but null or false), the `isset()` check passes, but the following code
might still use the undefined variable, leading to a PHP 'Undefined
Variable' notice/error.
This change corrects the logic by ensuring that the `$db` array
(which represents the database configuration being added) explicitly
contains the `'read'` and `'write'` keys, defaulting them to `1`
if they are not present in the configuration passed to the function.
This resolves potential runtime errors when calling `add_database`
with minimal configuration options.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Ensure $db read/write keys are defined in add_database
The HyperDB::add_database function was potentially exiting with undefined '$read' and '$write' variables if they were not passed in the initial configuration array.
This occurs because:
if ( ! isset( $read ) ) { $read = 1; }).isset()check passes, but the following code might still use the undefined variable, leading to a PHP 'Undefined Variable' notice/error.This change corrects the logic by ensuring that the
$dbarray (which represents the database configuration being added) explicitly contains the'read'and'write'keys, defaulting them to1if they are not present in the configuration passed to the function.This resolves potential runtime errors when calling
add_databasewith minimal configuration options.