Fix hardcoded dashboard expiration date format

[masteradhoc]

Fixes #2890

Changes Proposed in this Pull Request

• We should change the hardcoded dateformat for the Job Dashboard Shortcode. Currently it displays the date format hardcoded in the format 'M d, Y'. Now it will respect the settings set in WordPress.

Testing Instructions

• open /job-dashboard/ page. without the fix it will be displayed like this

After the fix it will be displayed according to your settings, in my example "j. F Y".

Release Notes

• fix hardcoded dashboard expiration date format

New or Updated Hooks and Templates

Deprecated Code

Screenshot / Video

[azaozz]

I'm pretty sure it is (almost) impossible to not have the date_format option set in WP, but just in case that happens somewhere this get_option() call will result in a trip to the DB (slow) and will return false which seems undesirable.

How about checking the option value before using it? Perhaps add something like:

$date_format = get_option( 'date_format' ) ?: 'M d, Y';

at the top then use $date_format in the HTML.

[masteradhoc]

@azaozz definately a valid point! adjusted the code as per your suggestion and fixed the docblock as the title was also wrong there. hope thats fine inside the same PR.

[azaozz]

Looks good, thanks!