Fix typo in field type check for wp_editor#2903
Closed
tripflex wants to merge 1 commit intoAutomattic:trunkfrom
Closed
Fix typo in field type check for wp_editor#2903tripflex wants to merge 1 commit intoAutomattic:trunkfrom
tripflex wants to merge 1 commit intoAutomattic:trunkfrom
Conversation
Collaborator
Author
|
@masteradhoc @yscik can we get this merged and an update released possibly? Numerous clients asking about it consistently |
Collaborator
|
+1 |
Contributor
|
I think no one is really working on this plugin at the moment. Last merges was done by @azaozz - maybe he can take a look? |
Collaborator
Author
|
I found this is actually correct (for some weird reason based on actual field type), so i'm going to close this ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like anytime someone has a custom WP Editor field type, the type check for field sanitation is checking for
wp_editorwhen the actual field type iswp-editor, this causes any custom WP Editor fields when saved to lose all formatting.Changes Proposed in this Pull Request
wp_editorwhich should bewp-editor(to match the actual field type value)Testing Instructions
wp_editortry again, and it works correctly.